On 09/11/2013 01:02 PM, Daniel P. Berrange wrote: >> >> <action id="org.libvirt.api.node-device.dettach"> >> >> [Ugg - did we REALLY mean to mis-spell detach? Is it too late to fix that?] > > The bug with using 'nodedevice' instead of 'node-device' means > no one could have made use of the permission 'dettach'. Given that > I think we can justifiably change it without it being a upgrade > problem / breakage. In general though permission names should be > considered ABI stable. Cool - one typo saves us from another. I agree with your justfication for fixing both typos at once. > >> >> ACK. > > So how about adding this ACK to that being squashed in. > > diff --git a/src/access/viraccessperm.c b/src/access/viraccessperm.c > index 17f6243..9c720f9 100644 > --- a/src/access/viraccessperm.c > +++ b/src/access/viraccessperm.c > @@ -58,7 +58,7 @@ VIR_ENUM_IMPL(virAccessPermNodeDevice, > VIR_ACCESS_PERM_NODE_DEVICE_LAST, > "getattr", "read", "write", > "start", "stop", > - "dettach"); > + "detach"); And thankfully, it appears to be the only permission with a typo'd name. Are there any doc pages that need manual updates, or is it all generated information that will auto-update to call out the corrected permission name? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list