This series adds the initialy omitted functionality of changing the <metadata> element using the virDomain[Get|Set]Metadata API. First few patches are cleanup of some code noticed during implementation of the other stuff. Peter Krempa (14): virsh-domain: Remove spurious ATTRIBUTE_UNUSED from cmdDesc virsh-domain: Line up signal names array qemu: Factor out body of qemuDomainGetMetadata for universal use qemu: Factor out body of qemuDomainSetMetadata for universal use conf: Factor out setting of metadata to simplify code util: Add helper to convert libxml2 nodes to a string virsh-domain: use virXMLNodeDump instead of xmlNodeDump virsh-domain: Add command to allow modifications of XML metadata conf: Add support for requesting of XML metadata via the API conf: allow to add XML metadata using the virDomainSetMetadata api lib: Don't force the key argument when deleting metadata lxc: Add metadata modification APIs test: Add <metadata> support into the test driver tests: Add metadata tests src/conf/domain_conf.c | 171 ++++++++++++++++++++++++++ src/conf/domain_conf.h | 17 +++ src/libvirt.c | 3 +- src/libvirt_private.syms | 4 + src/lxc/lxc_driver.c | 70 +++++++++++ src/qemu/qemu_driver.c | 122 ++----------------- src/test/test_driver.c | 68 +++++++++++ src/util/virxml.c | 187 +++++++++++++++++++++++++++++ src/util/virxml.h | 13 ++ tests/Makefile.am | 7 ++ tests/metadatatest.c | 245 ++++++++++++++++++++++++++++++++++++++ tools/virsh-domain.c | 304 ++++++++++++++++++++++++++++++++--------------- 12 files changed, 1001 insertions(+), 210 deletions(-) create mode 100644 tests/metadatatest.c -- 1.8.3.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list