Re: [PATCH] qemu: Remove unnecessary variable assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/06/2013 07:35 AM, Hongwei Bi wrote:
> Remove unnecessary 'addrs = NULL' in
> qemuDomainAssignS390Addresses() and
> qemuDomainAssignPCIAddresses() due to
> the related Free function in label cleanup.

But it is necessary, because we assign the value of addrs to priv->ccwaddrs.
If we didn't set addrs to NULL, it would get freed by that function in the
cleanup: section and priv->ccwaddrs would point to freed memory.

Jan

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]