Sorry, I did not notice this discrepancy. I prefer the "Liuji (Jeremy)" form. Next time, I will change the name of S-o-B from "Liu Ji" to "Liuji (Jeremy)". Thanks. > -----Original Message----- > From: Eric Blake [mailto:eblake@xxxxxxxxxx] > Sent: Thursday, September 05, 2013 10:08 PM > To: Liuji (Jeremy) > Cc: libvir-list@xxxxxxxxxx; pkrempa@xxxxxxxxxx; Jinbo (Justin); Luohao > (brian); Haofeng > Subject: Re: [PATCH] domain_conf: Delete the USB controller check > from the USB Device checklist on virDomainDeviceIsUSB > > On 09/04/2013 08:40 PM, Liuji (Jeremy) wrote: > > When using "virsh attach-device" to attach a device, the > virDomainDefCompatibleDevice function will check the compatibility. > > If the device is a USB device, but the VM don't have any USB controller, the > execution of "virsh attach-device" will fails. > > It considers the USB controller as a USB device on > > virDomainDeviceIsUSB, so we can't use "virsh attach-device" to attach a USB > controller for a VM which don't have any other USB controller. > > > > > Signed-off-by: Liu Ji <jeremy.liu@xxxxxxxxxx> > > Your mail From "Liuji (Jeremy)" differs from your S-o-B "Liu Ji". For the sake of a > clean 'git shortlog', I'd like to know which form you prefer, so we can stick an > entry in .mailmap to clean up the discrepancy. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list