On 09/05/13 13:03, Daniel P. Berrange wrote:
> On Wed, Sep 04, 2013 at 10:58:23AM +0800, Gao feng wrote:
>> Generate debug message when systemd doesn't support
>> interface org.freedesktop.machine1.Manager.
>>
>> Signed-off-by: Gao feng <gaofeng@xxxxxxxxxxxxxx>
>> ---
>> src/util/virsystemd.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c
>> index 3e69ef6..c631557 100644
>> --- a/src/util/virsystemd.c
>> +++ b/src/util/virsystemd.c
>> @@ -233,6 +233,7 @@ int virSystemdCreateMachine(const char *name,
>> if (err->code == VIR_ERR_DBUS_SERVICE &&
>> STREQ(err->str2, "org.freedesktop.DBus.Error.ServiceUnknown")) {
>> virResetLastError();
>> + VIR_DEBUG("systemd doesn't support interface org.freedesktop.machine1.Manager");
>
> Is this really needed ? The virRaiseError call will have already reported
> this scenario surely ?
Yes, it will. It is actually spamming the log with "error" messages
every time you start a VM on a non-systemd host even when it is later
successful using the old approach.
Peter
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list