On 09/04/2013 07:22 AM, Michal Privoznik wrote: > On 04.09.2013 04:52, Eric Blake wrote: >> 'make rpm' with client_local set to 1 (by manual modification, >> or with RHEL 5 on s390) warns: >> >> >> The bulk of these are fixed with this patch. >> >> * examples/xml/nwfilter/Makefile.am (install-data-local) >> (uninstall-local): Make conditional. >> >> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >> --- >> >> This is one alternative; see 3b/n for the other alternative (that >> is, I'm not sure whether it's better to have the Makefiles match >> the spec file layout, or to have the spec file paper over >> unconditional Makefiles). Preferences? >> > I like this approach more, since it fixes Makefile too. We shouldn't be > installing files we weren't requested. > > ACK to this version. Yay - that was my personal favorite, too. Looks like I have some followup patches to write, for the other instances of 'rm' in the spec file due to installing unnecessary stuff depending on options chosen. Pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list