Re: [PATCH] virNetDevVethCreate: assign names based on mac address by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 29, 2013 at 12:05:49AM +0300, Oskari Saarenmaa wrote:
> Interface names do not have to be numerical (or veth + number) and trying to
> assign them to that format is susceptible to race conditions.  Instead,
> assign the parent interface name according to the mac address (the last
> three bytes) if no name was given by the caller and use the parent interface
> name plus 'p' for the container name.
> 
> Signed-off-by: Oskari Saarenmaa <os@xxxxxxx>

NACK, I really don't like this proposed naming scheme. If there is a rac
with our current code we should be fixing that race.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]