Re: [PATCHv4 2/5] domifaddr: Implement the remote protocol

[Nehal J Wani <nehaljw.kkd1@xxxxxxxxx>]

s/ip/IP/,

+ */
+const REMOTE_DOMAIN_IP_ADDR_MAX = 16;

hm, are these 2 limits too small? I don't believe one host could only have
up to 32 interfaces.  Any evidence for you to descrease them in new series?

Osier

Since there is no theoretical limit on the number of interfaces that a physical

or virtual machine can have, I would suggest making 

REMOTE_DOMAIN_INTERFACE_MAX = 2048

and

REMOTE_DOMAIN_IP_ADDR_MAX = 2048

Earlier there used to be limitation defined in /usr/include/linux/net_alias.h: 

" #define NET_ALIAS_MAX_SLOT  256" but then the kernel developers thought

 that "limits suck" and removed them after kernel 2.0.

I have tested creating multiple ipv4 aliases on the same interface and was able

to achieve the count of 1010 without any warnings/errors.

--

Nehal J Wani

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list