On Thu, Aug 22, 2013 at 09:19:14PM +0200, Giuseppe Scrivano wrote: > 4 files changed, 115 insertions(+), 1 deletion(-) > diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x > index 7cfebdf..924d629 100644 > --- a/src/remote/remote_protocol.x > +++ b/src/remote/remote_protocol.x > @@ -2837,6 +2837,15 @@ struct remote_domain_event_device_removed_msg { > remote_nonnull_string devAlias; > }; > > +struct remote_connect_get_cpu_model_names_args { > + remote_nonnull_string arch; > + unsigned int flags; > +}; > + > +struct remote_connect_get_cpu_model_names_ret { > + remote_nonnull_string models<>; Use of <> is forbidden - please define a constant for the upper bound of this array and check the length on both client and server side. (Yes, some existing APIs don't do this & they are being fixed). Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list