On Wed, Aug 21, 2013 at 06:43:16PM +0200, Paolo Bonzini wrote: > The pvpanic situation is already messed up enough. Let us give our > libvirt friends an easy indication that we have untied our side. > > Not-yet-signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > ... because we first have to determine how to expose the device's existence > in the ACPI tables or in fw_cfg. > > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> So it's isa-pvpanic meaning "I-am-sure-this-is-the-last-bug-pvpanic" If we feel there's need to give libvirt a way to do introspection into QEMU bugs, let's architect one. Randomly renaming devices in the vain hope it's the last major bug is not it. NACK > --- > hw/misc/pvpanic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > index 1928cc9..b53011d 100644 > --- a/hw/misc/pvpanic.c > +++ b/hw/misc/pvpanic.c > @@ -27,7 +27,7 @@ > /* The pv event value */ > #define PVPANIC_PANICKED (1 << PVPANIC_F_PANICKED) > > -#define TYPE_ISA_PVPANIC_DEVICE "pvpanic" > +#define TYPE_ISA_PVPANIC_DEVICE "isa-pvpanic" > #define ISA_PVPANIC_DEVICE(obj) \ > OBJECT_CHECK(PVPanicState, (obj), TYPE_ISA_PVPANIC_DEVICE) > > -- > 1.8.3.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list