On 08/09/2013 06:56 AM, Michal Privoznik wrote: > This function is to guess the correct limit for maximal memory > usage by qemu for given domain. This can never be guessed > correctly, not to mention all the pains and sleepless nights this > code has caused. Once somebody discovers algorithm to solve the > Halting Problem, we can compute the limit algorithmically. But > till then, this code should never see the light of the release > again. > --- > src/qemu/qemu_cgroup.c | 3 +-- > src/qemu/qemu_command.c | 2 +- > src/qemu/qemu_domain.c | 49 ------------------------------------------------- > src/qemu/qemu_domain.h | 2 -- > src/qemu/qemu_hotplug.c | 2 +- > 5 files changed, 3 insertions(+), 55 deletions(-) ACK. Users that put an explicit limit in their XML are taking on their own risk at guessing correctly; all other users should not be forced to suffer from a bad guess on our part killing their domain. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list