On 08/09/2013 07:01 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > The virLoginShellAllowedUser method must not free the 'groups' > parameter it is given, as that is owned by the caller. > > The virLoginShellAllowedUser method should be checking > '!*ptr' (ie empty string) rather than '!ptr' (NULL string) > since the latter cannot be true. > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > --- > tools/virt-login-shell.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > ACK John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list