Eric Blake wrote: > On 08/08/2013 02:04 PM, Jim Fehlig wrote: > >> virt-login-shell.c was failing to compile with >> >> CC virt_login_shell-virt-login-shell.o >> virt-login-shell.c: In function 'main': >> virt-login-shell.c:205:5: error: implicit declaration of function 'setlocale' [-Werror=implicit-function-declaration] >> virt-login-shell.c:205:5: error: nested extern declaration of 'setlocale' [-Werror=nested-externs] >> virt-login-shell.c:205:20: error: 'LC_ALL' undeclared (first use in this function) >> --- >> >> I'm a little surprised that others are not seeing this problem, so a bit >> nervious committing without an ACK. >> > > ACK - go for it. It depends on which version of glibc you use as to > whether you see the error (I reproduced it with glibc 2.17 of Fedora 19, > but suspect that Dan Walsh developed the patch on an older platform). > Ah, I see. I noticed the issue with glibc 2.17 as well. Thanks, pushed now. Regards, Jim -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list