On 08/01/2013 02:06 PM, John Ferlan wrote:
> Coverity reported the existing missing check of the return value and
> subsequent use from a call to virJSONValueFromString() in testJSONAddRemove().
> ---
> tests/jsontest.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
ACK.
>
> diff --git a/tests/jsontest.c b/tests/jsontest.c
> index a37a980..1d385d4 100644
> --- a/tests/jsontest.c
> +++ b/tests/jsontest.c
> @@ -60,11 +60,17 @@ testJSONAddRemove(const void *data)
> {
> const struct testInfo *info = data;
> virJSONValuePtr json;
> - virJSONValuePtr name;
> + virJSONValuePtr name = NULL;
> char *result = NULL;
> int ret = -1;
>
> json = virJSONValueFromString(info->doc);
> + if (!json) {
> + if (virTestGetVerbose())
> + fprintf(stderr, "Fail to parse %s\n", info->doc);
> + ret = -1;
> + goto cleanup;
> + }
>
> switch (virJSONValueObjectRemoveKey(json, "name", &name)) {
> case 1:
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list