On 07/30/2013 07:05 AM, Peter Krempa wrote: > The qemumonitorjsontest crashed when one of the initialization steps > done before starting the worker thread failed. This patch fixes this by > trying to pthread_join() the thread only after it was created. > --- > tests/qemumonitortestutils.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) ACK. > > diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c > index 34ca1ae..5ca569f 100644 > --- a/tests/qemumonitortestutils.c > +++ b/tests/qemumonitortestutils.c > @@ -368,7 +368,8 @@ qemuMonitorTestFree(qemuMonitorTestPtr test) > > virObjectUnref(test->vm); > > - virThreadJoin(&test->thread); > + if (test->running) > + virThreadJoin(&test->thread); > > if (timer != -1) > virEventRemoveTimeout(timer); > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list