Most APIs in libvirt report errors, thus no need to state that explictly. --- src/qemu/qemu_agent.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index fc85e3e..2cd0ccc 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -930,10 +930,8 @@ qemuAgentGuestSync(qemuAgentPtr mon) VIR_DEBUG("qemuAgentSend returned: %d", send_ret); - if (send_ret < 0) { - /* error reported */ + if (send_ret < 0) goto cleanup; - } if (!sync_msg.rxObject) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -976,10 +974,8 @@ qemuAgentCommand(qemuAgentPtr mon, *reply = NULL; - if (qemuAgentGuestSync(mon) < 0) { - /* helper reported the error */ + if (qemuAgentGuestSync(mon) < 0) return -1; - } memset(&msg, 0, sizeof(msg)); -- 1.8.3.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list