On 07/29/2013 10:40 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > The way we were casting small (<32bit) integers was broken > on big endian hosts, causing stack smashing. This was detected > in the test suite either by test failures due to incorrect > results, or by libc/gcc abort'ing with its stack canary > triggered. > > In v2: > > - Added missing change to virdbus.c The v2 designation can be trimmed before you push; it helps review, but doesn't need to live in libvirt.git. > case DBUS_TYPE_UINT16: > - GET_NEXT_VAL(dbus_uint16_t, unsigned int, "%d"); > + GET_NEXT_VAL(dbus_uint16_t, short unsigned, "%d"); Works, but 'unsigned short' is a bit more typical. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list