On Wed, Jul 24, 2013 at 03:29:03PM -0600, Eric Blake wrote: > On 07/22/2013 08:48 AM, Ján Tomko wrote: > > Check if PCI bridges with duplicate indexes are rejected. > > PCI root controllers with non-zero indexes or addresses should > > also be rejected. > > --- > > .../qemuxml2argv-pci-bridge-duplicate-index.xml | 16 ++++++++++++++++ > > tests/qemuxml2argvdata/qemuxml2argv-pci-root-address.xml | 16 ++++++++++++++++ > > .../qemuxml2argv-pci-root-nonzero-index.xml | 14 ++++++++++++++ > > tests/qemuxml2argvtest.c | 6 ++++++ > > 4 files changed, 52 insertions(+) > > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-bridge-duplicate-index.xml > > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-root-address.xml > > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-root-nonzero-index.xml > > ACK. Adding test cases is always safe, even in freeze. Famous last words :-) If maintaining libvirt has taught me anything, it is that nothing is completely safe :-P Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list