On 07/11/13 18:10, Daniel P. Berrange wrote:
On Wed, Jul 10, 2013 at 08:42:03AM +0200, Peter Krempa wrote:Previously a connection object was required to retrieve the auth credentials. This patch adds the option to call the retrieval functions only using the connection URI or path to the configuration file. This will allow to use this toolkit to request passwords for ssh authentication in the libssh2 connection driver. Changes: *virAuthGetConfigFilePathURI(): use URI to retrieve the config file path *virAuthGetCredential(): Remove the need to propagate conn object virAuthGetPasswordPath(): *virAuthGetUsernamePath(): New functions, that use config file path instead of conn object --- src/util/virauth.c | 107 +++++++++++++++++++++++++++++++++++++---------------- src/util/virauth.h | 17 ++++++++- 2 files changed, 91 insertions(+), 33 deletions(-)ACK I won't force you to write a test case for this, since we don't already have a test virauth.h file APIs. If you should wish to write one anyway though.....
I will put that on my to-do list. I actually was thinking about testing this while writing the code.
Daniel
Series pushed, thanks for the review. Peter -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list