On Wed, Jul 10, 2013 at 07:02:57PM +0200, Michal Privoznik wrote: > The function being introduced is responsible for creating command > line argument for '-device' for given character device. Based on > the chardev type, it calls appropriate qemuBuild.*ChrDeviceStr(), > e.g. qemuBuildSerialChrDeviceStr() for serial chardev and so on. > --- > src/qemu/qemu_command.c | 202 +++++++++++++++++++++++++++++++++++++----------- > src/qemu/qemu_command.h | 12 +-- > 2 files changed, 163 insertions(+), 51 deletions(-) ACK, I'm assuming we have test coverage already that is validating this code. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list