On Mon, Jul 08, 2013 at 03:20:30PM -0400, John Ferlan wrote:
> Add a period in seconds to allow/enable statistics gathering from the
> Balloon driver for 'virsh dommemstat <domain>'.
> ---
> docs/formatdomain.html.in | 10 ++++++++++
> docs/schemas/domaincommon.rng | 7 +++++++
> src/conf/domain_conf.c | 44 +++++++++++++++++++++++++++++++++++++------
> src/conf/domain_conf.h | 1 +
> 4 files changed, 56 insertions(+), 6 deletions(-)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index c135530..7a6852b 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -2946,6 +2946,13 @@
> <optional>
> <ref name="address"/>
> </optional>
> + <optional>
> + <element name="stats">
> + <attribute name="period">
> + <ref name="positiveInteger"/>
This says 'unsigned int'
> + </attribute>
> + </element>
> + </optional>
> </element>
> </define>
> <define name="parallel">
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 402e6e9..d63b735 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> + if (period < 0) {
> + virReportError(VIR_ERR_XML_ERROR, "%s",
> + _("period value must be 0 or more"));
> + goto error;
> + }
And this says unsigned int.
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index da83eb6..a8eb1fe 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -1533,6 +1533,7 @@ enum {
> struct _virDomainMemballoonDef {
> int model;
> virDomainDeviceInfo info;
> + int period; /* seconds between collections */
But this is signed. Please change to be unsigned.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list