Re: [PATCH v2 01/37] viralloc: Report OOM error on failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/09/13 17:09, Michal Privoznik wrote:
Similarly to VIR_STRDUP, we want the OOM error to be reported in
VIR_ALLOC and friends.
---
  po/POTFILES.in                  |   1 +
  python/libvirt-override.c       | 102 +++++++++---------
  src/conf/domain_conf.c          |  15 +--
  src/conf/network_conf.c         |  50 ++++-----
  src/esx/esx_vi.c                |   2 +-
  src/lxc/lxc_process.c           |   8 +-
  src/security/security_manager.c |   2 +-
  src/security/security_selinux.c |   3 +-
  src/util/viralloc.c             | 166 ++++++++++++++++++++++++----
  src/util/viralloc.h             | 234 ++++++++++++++++++++++++++++++++++------
  src/util/virbuffer.c            |   8 +-
  src/util/vircgroup.c            |   2 +-
  src/util/virerror.c             |   4 +-
  src/util/virlog.c               |  12 +--
  src/util/virpci.c               |   4 +-
  src/util/virthreadpthread.c     |   2 +-
  tests/commandhelper.c           |   1 +
  tests/networkxml2conftest.c     |   2 +
  tests/test_conf.c               |   2 +-
  tests/xmconfigtest.c            |   2 +
  20 files changed, 459 insertions(+), 163 deletions(-)


ACK, you addressed my most critical comments.

Peter

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]