Hi Eric, On Tue, Jul 02, 2013 at 03:48:04PM -0600, Eric Blake wrote: > On 07/02/2013 03:36 PM, Guido Günther wrote: > > as indicates by the filename. > > s/indicates/indicated/ > > > --- > > tools/Makefile.am | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tools/Makefile.am b/tools/Makefile.am > > index 1dac7c1..644a86d 100644 > > --- a/tools/Makefile.am > > +++ b/tools/Makefile.am > > @@ -99,7 +99,8 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile > > || (rm $@ && exit 1) && chmod +x $@ > > > > virt-sanlock-cleanup.8: virt-sanlock-cleanup.in $(top_srcdir)/configure.ac > > - $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP $< $(srcdir)/$@ \ > > + $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP --section=8 \ > > + $< $(srcdir)/$@ \ > > It would be nice if pod2man could auto-detect --section based on its > destination argument name (hmm, the man page says it already does just > that for .pm files, but not for .8). But as we must operate with > existing software rather than waiting for a new pod2man, your patch > makes sense. I didn't check if RHEL 5's pod2man supports the option, > but I guess I'll deal with any followup patches if I later run into > problems attempting 'make dist' from a RHEL 5 box. > > Looks like daemon/Makefile.am needs the same tweak for libvirtd.8. Since libvirtd.8.in in processed by sed and not pod2man it doesn't need any additional tweaks. Or am I missing something? It's only the reference inside virt-sanlock-cleanup's manpage that's wrong. It states it's virt-sanlock-cleanup(1) while it's virt-sanlock-cleanup(8). So o.k. to push with only the s/indicates/indicated/ fixed? Cheers, -- Guido -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list