On 06/20/2013 04:18 AM, Ján Tomko wrote:
> On 06/19/2013 10:44 PM, John Ferlan wrote:
>> As a consequence of the cgroup layout changes from commit '632f78ca', the
>> qemuDomainGetSchedulerParameters[Flags]()' and qemuGetSchedulerType() APIs
>> failed to return data for a non running domain. This can be seen through
>> a 'virsh schedinfo <domain>' command which returns:
>>
>> Scheduler : Unknown
>> error: Requested operation is not valid: cgroup CPU controller is not mounted
>>
>> Prior to that change a non running domain would return:
>>
>> Scheduler : posix
>> cpu_shares : 0
>> vcpu_period : 0
>> vcpu_quota : 0
>> emulator_period: 0
>> emulator_quota : 0
>>
>> This patch will restore the capability to return configuration only data
>> for a non running domain regardless of whether cgroups are available.
>>
>> NOTE: Needed to change the VIR_STRDUP(ret, "posix"); to ret = strdup("posix");
>
> VIR_STRDUP also reports the OOM error, so the strdup equivalent would be:
> if (!(ret = strdup("posix")))
> virReportOOMError();
>
> Jan
>
Ah yes, how quickly we forget.
I added/squashed in a check for the OOM and pushed along with the git
commit id from whence I cherry picked.
John
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list