On Mon, Jun 03, 2013 at 11:19:15AM +0100, Daniel P. Berrange wrote: > On Wed, May 22, 2013 at 10:00:12AM +0200, Manuel VIVES wrote: > > Hello, > > > > I'm re-sending this patch for reviewing. > > If necessary I'm willing to make > > some changes to those patches. > > > > I'm currently working on a better management for snapshots with virtualbox, > > and my work is based on Virtualbox 4.2 so that's why I'm re sending this patch. > > > > Regards, > > Manuel VIVES > > > > Ryan Woodsmall said originally: > > > > "This patch set adds VirtualBox 4.2 initial support for the libvirt vbox driver. > > I've tested enough to check capabilities, create a VM, destroy it, etc. Five > > patches total: > > > > - Patch 1 is the C API header file from Oracle, cleaned up for libvirt. > > - Patch 2 is the version specific source file for version dependency. > > - Patch 3 is the src/Makefile.am change to pick up the two new files. > > - Patch 4 is the vbox driver support for the new VirtualBox API/version. > > - Patch 5 is the vbox_tmpl.c template support for the new version. > > > > A few things have changed in the VirtualBox API - some small (capitalizations > > of things in function names like Ip to IP and Dhcp to DHCP) and some much larger > > (FindMedium is superceded by OpenMedium). The biggest change for the sake of this > > patch set is the signature of CreateMachine is quite a bit different. Using the > > Oracle source as a guide, to spin up a VM with a given UUID, it looks like a text > > flag has to be passed in a new argument to CreateMachine. This flag is built in the > > VirtualBox 4.2 specific ifdefs and is kind of ugly but works. Additionally, there > > is now (unused) VM groups support in CreateMachine and the previous 'osTypeId' arg > > is currently set to nsnull as in the Oracle code. > > > > The FindMedium to OpenMedium changes were more straightforward and are pretty clear. > > The rest of the vbox template changes are basically spelling/capitalization changes > > from the looks of things. > > > > This probably isn't perfect, but it works on git and patched against 0.10.2 for a > > few quick tests. Not currently on the list, so ping me directly if you need any > > other info on these, or if anything could use additional work. Thanks! " > > > > ryan woodsmall (5): > > vbox C API header for VirtualBox v4.2 > > vbox version-specific C file for VirtualBox v4.2 > > Makefile.am additions for VirtualBox v4.2 > > vbox driver support for VirtualBox v4.2 > > vbox template support for VirtualBox v4.2 > > > > src/Makefile.am | 3 +- > > src/vbox/vbox_CAPI_v4_2.h | 8855 +++++++++++++++++++++++++++++++++++++++++++++ > > src/vbox/vbox_V4_2.c | 13 + > > src/vbox/vbox_driver.c | 8 + > > src/vbox/vbox_tmpl.c | 90 +- > > 5 files changed, 8958 insertions(+), 11 deletions(-) > > create mode 100644 src/vbox/vbox_CAPI_v4_2.h > > create mode 100644 src/vbox/vbox_V4_2.c > > ACK to all pastches, they look like the sane minimum required to make > vbox 4.2 work. This is now pushed, though I had to merge all 5 patches into 1, since they would not compile individually & we require history to be fully bisectable at every patch. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list