Re: [PATCH 5/6] nodedev: Support SCSI_GENERIC cap flag for listAllNodeDevices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/03/2013 06:05 AM, Osier Yang wrote:
> ---
>  include/libvirt/libvirt.h.in | 1 +
>  src/conf/node_device_conf.c  | 4 +++-
>  src/conf/node_device_conf.h  | 3 ++-
>  3 files changed, 6 insertions(+), 2 deletions(-)
> 

ACK....

Seems reasonable - although the last time you updated
virConnectListAllNodeDeviceFlags you also changed libvirt.c to add
VIR_CONNECT_LIST_NODE_DEVICES_CAP_FC_HOST and
VIR_CONNECT_LIST_NODE_DEVICES_CAP_VPORTS to the documented list of flags
in virConnectListAllNodeDevices().  I would think you'd need to add
VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_GENERIC too.


I used cscope search on VIR_CONNECT_LIST_NODE_DEVICES_CAP in order to
find that.


John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]