Eric Blake wrote: > On 06/05/2013 05:38 AM, Laine Stump wrote: > >> On 06/04/2013 07:02 PM, Eric Blake wrote: >> >>> On the other hand; WITH_NWFILTER controlls what libvirtd provides, not >>> what the client can do. Technically, even on a machine where the client >>> was built without nwfilter support, that client can still talk to a >>> libvirtd with nwfilter enabled, at which point the examples are still >>> usable. >>> >> This makes sense to me. What do we do for other similar functionality? >> > > Weird. examples/xml/nwfilter is the only subdirectory of examples/xml > that installs anything in the first place. All other > examples/xml/*/*.xml files that get installed are done via the top-level > Makefile.am using a generic XML_EXAMPLES wildcard. Maybe we just need > to remove examples/xml/nwfilter/Makefile.am and consolidate it into the > top-level alongside the other examples. > This sounds reasonable to me... > Meanwhile, I was looking whether examples/xml/storage/pool-netfs.xml > might be a case of something that is conditional on build flags (not all > libvirtd support netfs), and since that appears to be installed > unconditionally, that is another argument for making nwfilter examples > unconditional. > particularly if we just want to install the nwfilter examples unconditionally. Should I pursue a patch along these lines? > I also wonder if our current installation of examples/xml/** under the > libvirt-devel subpackage, instead of under the libvirt-docs subpackage, > makes sense. Good question. The libvirt-devel subpackage already requires libvirt-docs subpackage, so seems the examples should be stuffed in the docs subpackage. Regards, Jim -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list