Re: [libvirt-designer PATCHv3 7/9] Implement gvir_designer_domain_add_usb_redir()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 04, 2013 at 07:11:05PM +0200, Michal Privoznik wrote:
> > 
> > diff --git a/examples/virtxml.c b/examples/virtxml.c
> > index 46fb551..bd3bfb3 100644
> > --- a/examples/virtxml.c
> > +++ b/examples/virtxml.c
> > @@ -566,6 +566,7 @@ main(int argc, char *argv[])
> >      static char *resources_str = NULL;
> >      GVirDesignerDomainResources resources;
> >      GOptionContext *context = NULL;
> > +    unsigned int i;
> >  
> >      static GOptionEntry entries[] =
> >      {
> > @@ -645,6 +646,10 @@ main(int argc, char *argv[])
> >                                                       GVIR_DESIGNER_DOMAIN_GRAPHICS_SPICE,
> >                                                       &error));
> >      CHECK_ERROR;
> > +    for (i = 0; i < 4; i++) {
> > +        g_object_unref(gvir_designer_domain_add_usb_redir(domain, &error));
> > +        CHECK_ERROR;
> > +    }
> 
> Why 4 times? Moreover, I'd rather see this as optional.

You need one redir channel per USB device you want to be able to redirect
simultaneously, I'll make USB redirection optional indeed, though I'll probably keep
a hardcoded '4' for now, this can be tweaked later.

Christophe

Attachment: pgpqLBLxJGr_m.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]