On Fri, May 17, 2013 at 08:27:34AM -0600, Eric Blake wrote:
> On 05/17/2013 07:29 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> >
> > Now the VirtualBox driver is a loadable module, it needs
> > to live in its own sub-RPM
> >
> > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> > ---
> > libvirt.spec.in | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 51 insertions(+)
>
> > +
> > + %if %{with_vbox}
> > +%package daemon-vbox
> > +Summary: Server side daemon & driver required to run VirtualBoxguests
>
> s/VirtualBoxguests/VirtualBox guests/
>
> > +Group: Development/Libraries
> > +
> > +Requires: libvirt-daemon = %{version}-%{release}
> > + %if %{with_driver_modules}
> > + %if %{with_vbox}
>
> Kill this %if. It's redundant with the condition a few lines earlier
> (the Requires can be unconditional).
>
> > +Requires: libvirt-daemon-driver-vbox = %{version}-%{release}
> > + %endif
>
> ACK with those fixes.
>
> Do we need a followup patch to mingw-libvirt.spec.in?
Once I'm able to successfully build mingw32 on F19 again I'll be
checking this :-)
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list