On Sun, May 12, 2013 at 11:52:22PM +0200, Christophe Fergeau wrote: > libvirt commit > http://libvirt.org/git/?p=libvirt.git;a=commit;h=e2c41e486018ee74f6a75c1f717622 > strongly hints that driver type for a disk domain should be an > enum rather than a raw string. Since we already have setters/getters > for this attribute, the alternate versions have an _enum suffix. > I did not set "Rename to: gvir_config_domain_disk_[gs]et_driver_type" > in a gtk-doc comment to force bindings to use this better version > as this would break Boxes for example. Rather than using an _enum suffix, how about just giving it a different name. The word 'type' is really bogus in our XML schema - it should have been 'format'. eg gvir_config_domain_disk_[sg]et_driver_format Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list