On 05/01/2013 11:53 AM, John Ferlan wrote:
> The following patches resolve a couple of Coverity issues. The 'lxc' change
> is merely a work-around by adding a Coverity tag to avoid what I consider to
> be a false positive. Another option to resolving is to change the code in
> lxcContainerPrepareRoot() to assign 'tmp = root->src' and then VIR_FREE(tmp)
> instead. I have submitted a bug to Coverity for this. The issue first
> showed up earlier this month and I've tried various ways to resolve without
> much luck. The 'virsh' change is from a more recent change where the ':'
> option processing was changed in such a way that Coverity's analysis found
> a missing break. The loop in question should find a match with optopt, but
> if it didn't it would have fallen into the '?' code.
>
> John Ferlan (2):
> lxc: Coverity false positive USE_AFTER_FREE
> virsh: Resolve Coverity 'MISSING_BREAK'
>
> src/lxc/lxc_container.c | 5 +++++
> tools/virsh.c | 10 +++++++---
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
Pushed w/ adj to 1/2 to remove extraneous {}
Thanks,
John
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list