On 05/07/2013 01:51 AM, Ján Tomko wrote:
> On 05/06/2013 03:19 PM, Guannan Ren wrote:
>> QEMU_CAPS_VNC_DISPLAY_POLICY (qemu >= v1.10)
Huh? qemu is at 1.5, not 1.10. Based on your code, you meant 1.1.
>> - if (version >= 1001000)
>> + if (version >= 1001000) {
>> virQEMUCapsSet(qemuCaps, QEMU_CAPS_IPV6_MIGRATION);
>> + virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC_DISPLAY_POLICY);
>> + }
>>
>> if (version >= 1002000)
>> virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY);
>
> Is there a help string we could look for instead of setting it based on version?
Yuck - it looks like neither 1.1 nor 1.2 exposed this information in
their -help output (at least, based on tests/qemuhelpdata contents). I
don't see any -device probing we can do either. Even with the new
query-command-line-options in qemu 1.5-rc1 (hmm, my patch series is
still pending[1]), I get an error trying to do
{"execute":"query-command-line-options","arguments":{"option":"vnc"}}
{"error": {"class": "GenericError", "desc": "invalid option name: vnc"}}
I think we are indeed stuck with a hard-coded version probe, which is
annoying for backport purposes.
[1] https://www.redhat.com/archives/libvir-list/2013-April/msg01968.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list