On Fri, May 03, 2013 at 06:04:11AM -0600, Eric Blake wrote: > On 05/03/2013 12:22 AM, Guido Günther wrote: > > In the non linux case some callers like gather_scsi_host_caps needed the > > return code of -1 while others like update_caps needed an emtpy > > s/emtpy/empty/ > > > statement (to avoid a "statement without effect" warning). This is much > > simpler solved by using a function instead of a define. > > --- > > src/node_device/node_device_driver.h | 11 +---------- > > src/node_device/node_device_linux_sysfs.c | 10 +++++++++- > > 2 files changed, 10 insertions(+), 11 deletions(-) > > ACK. With these we have the kFreeBSD builds back: https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental Thanks a lot! Unfortunately I failed to add a kFreeBSD Jenkins yet since we dont have OpenJDK and gcj doesn't seem to be up to the job: http://lists.debian.org/debian-java/2013/05/msg00006.html But doing it over ssh will do for now: http://honk.sigxcpu.org:8001/job/libvirt-build-debian-jessie-kfreebsd64/ Cheers, -- Guido > > > +int > > +detect_scsi_host_caps(union _virNodeDevCapData *d ATTRIBUTE_UNUSED) > > It would eventually be nice to rename this virDetectScsiHostCaps, but > that can be a cleanup for another day; your patch is fine for the > build-breaker on FreeBSD that Roman reported. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > -- > libvir-list mailing list > libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list