Eric Blake wrote: > These fixes solve a compilation failure on FreeBSD: > > util/virnetdevtap.c: In function 'virNetDevTapGetName': > util/virnetdevtap.c:56: warning: unused parameter 'tapfd' [-Wunused-parameter] > util/virnetdevtap.c:56: warning: unused parameter 'ifname' [-Wunused-parameter] > > * src/util/virnetdevtap.c (virNetDevTapGetName): Add attributes > when TUNGETIFF is not present. Thanks for that fix as well. Can you actually compile it successfully without '--disable-werror'? It fails for me because of gcrypt.h: http://people.freebsd.org/~novel/misc/libvirt_gcrypt_warns.txt When configured with '--without-gnutls', it fails again in remote_protocol.c: http://people.freebsd.org/~novel/misc/libvirt_remote_protocol_warns.txt Going further and disabling remote results in another failure: http://people.freebsd.org/~novel/misc/libvirt_node_devices_warns.txt Roman Bogorodskiy
Attachment:
pgpg25wFRHq3m.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list