On 04/30/2013 09:18 AM, John Ferlan wrote:
> On 04/30/2013 10:42 AM, Martin Kletzander wrote:
>> Adding support for new attribute 'websocket' in the '<graphics>'
>> element, the attribute value is the port to listen on with '-1'
>> meaning auto-allocation, '0' meaning no websockets.
>>
>> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
>> ---
>>
>> + if (websocket) {
>> + if (virStrToLong_i(websocket,
>> + NULL, 10,
>> + &def->data.vnc.websocket) < 0) {
>> + virReportError(VIR_ERR_INTERNAL_ERROR,
>> + _("cannot parse vnc websocket port %s"), port);
>
> I think you meant websocket, not port for the string... it's a
> cut-n-paste error it seems.
>
> "port" will be VIR_FREE()'d already (or it may not have been found, so
> it's already NULL.
But I like the proposal, and agree with the docs calling it out as 1.0.6
material.
ACK with John's finding fixed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list