On 04/29/2013 07:56 AM, Ján Tomko wrote:
> My commit 024e9af broke this.
> ---
> src/qemu/qemu_command.c | 3 ---
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index d23bdfc..d161b56 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -8540,7 +8540,6 @@ qemuParseCommandLineDisk(virDomainXMLOptionPtr xmlopt,
> def->bus = VIR_DOMAIN_DISK_BUS_IDE;
> def->device = VIR_DOMAIN_DISK_DEVICE_DISK;
> def->type = VIR_DOMAIN_DISK_TYPE_FILE;
> - def->format = VIR_STORAGE_FILE_AUTO;
>
> for (i = 0 ; i < nkeywords ; i++) {
> if (STREQ(keywords[i], "file")) {
> @@ -9788,8 +9787,6 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr qemuCaps,
> if (VIR_ALLOC(disk) < 0)
> goto no_memory;
>
> - disk->format = VIR_STORAGE_FILE_AUTO;
> -
ACK. Using VIR_STORAGE_FILE_AUTO would be a security hole if it
contradicts the user's configuration. Thanks for fixing this pre-release.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list