On 29.04.2013 16:52, Martin Kletzander wrote:
> This series, which is meant to be applied _after_ 1.0.5 release, is
> adding support for the VNC WebSocket to be configured for QEMU.
>
> I tagged this with [RFC] because this is the fastest way I managed to
> code it and I'd welcome any opinions on naming changes etc.
>
>
> Documentation from qemu_options.hx:
>
> qemu -vnc ...,websocket[=<port>]
> Opens an additional TCP listening port dedicated to VNC Websocket connections.
> By definition the Websocket port is 5700+@var{display}. If @var{host} is
> specified connections will only be allowed from this host.
> As an alternative the Websocket port could be specified by using
> @code{websocket}=@var{port}.
>
>
> Martin Kletzander (2):
> Add VNC WebSocket support
> qemu: Add VNC WebSocket support
>
> docs/formatdomain.html.in | 5 ++
> docs/schemas/domaincommon.rng | 5 ++
> src/conf/domain_conf.c | 18 +++++++
> src/conf/domain_conf.h | 1 +
> src/qemu/libvirtd_qemu.aug | 4 +-
> src/qemu/qemu.conf | 7 +++
> src/qemu/qemu_capabilities.c | 5 ++
> src/qemu/qemu_capabilities.h | 1 +
> src/qemu/qemu_command.c | 60 +++++++++++++++++++++-
> src/qemu/qemu_command.h | 5 +-
> src/qemu/qemu_conf.c | 32 ++++++++++++
> src/qemu/qemu_conf.h | 6 +++
> src/qemu/qemu_driver.c | 5 ++
> src/qemu/qemu_process.c | 31 ++++++++---
> src/qemu/test_libvirtd_qemu.aug.in | 2 +
> tests/qemuargv2xmltest.c | 1 +
> .../qemuxml2argv-graphics-vnc-websocket.args | 4 ++
> .../qemuxml2argv-graphics-vnc-websocket.xml | 35 +++++++++++++
> tests/qemuxml2argvtest.c | 1 +
> tests/qemuxml2xmltest.c | 1 +
> 20 files changed, 219 insertions(+), 10 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-websocket.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-websocket.xml
>
I've found some tiny nits. But I like the idea overall.
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list