On 04/26/2013 10:31 AM, Ján Tomko wrote: > I removed it in 5c3d5b2 by accident. > --- > src/conf/domain_conf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 3c6d260..88e3d93 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -9924,6 +9924,7 @@ virDomainDefMaybeAddController(virDomainDefPtr def, > > if (VIR_APPEND_ELEMENT(def->controllers, def->ncontrollers, cont) < 0) { > VIR_FREE(cont); > + virReportOOMError(); > return -1; We may be removing it again once the VIR_STRDUP stuff lands to push OOM reporting into viralloc.c; but for now this patch is right. ACK; series belongs in 1.0.5. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list