Re: [PATCH 3/7] hypervisor api: new virNodeDeviceDetachFlags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/24/2013 01:26 PM, Laine Stump wrote:
> The existing virNodeDeviceDettach() assumes that there is only a
> single PCI device assignment backend driver appropriate for any
> hypervisor. This is no longer true, as the qemu driver is getting
> support for PCI device assigment via VFIO. The new API

s/assigment/assignment/

> virNodeDeviceDetachFlags adds a driverName arg that should be set to
> the exact same string set in a domain <hostdev>'s <driver name='x'/>
> element (i.e. "vfio", "kvm", or NULL for default). It also adds a
> flags arg for good measure (and because it's possible we may need it
> when we start dealing with VFIO's "device groups").
> ---
>  include/libvirt/libvirt.h.in |  5 +++-
>  src/driver.h                 |  6 ++++
>  src/libvirt.c                | 69 ++++++++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms      |  5 ++++
>  4 files changed, 84 insertions(+), 1 deletion(-)

Looks good; and we should definitely get this in before freeze if we
plan on having the API as part of 1.0.5.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]