On 04/23/2013 04:26 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > Ensure that the virDrvXXX method names exactly match > the public APIs virYYY method names. ie XXX == YYY. > Add a test case to prevent any regressions. > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > --- > docs/hvsupport.pl | 2 +- > src/Makefile.am | 11 +- > src/check-drivername.pl | 53 +++++++++ > src/driver.h | 304 ++++++++++++++++++++++++------------------------ > src/xen/xen_driver.h | 10 +- > 5 files changed, 221 insertions(+), 159 deletions(-) > create mode 100644 src/check-drivername.pl Again, mostly mechanical, with a test to enforce it. ACK with minor nits: > diff --git a/src/check-drivername.pl b/src/check-drivername.pl > new file mode 100644 Please chmod +x this file. > index 0000000..f92316d > --- /dev/null > +++ b/src/check-drivername.pl > @@ -0,0 +1,53 @@ > +#!/usr/bin/perl > + We probably ought to add a copyright notice to this file (and to the other check-*.pl files in the directory). > typedef int > - (*virDrvListDefinedDomains) (virConnectPtr conn, > - char **const names, > - int maxnames); > + (*virDrvConnectListDefinedDomains) (virConnectPtr conn, > + char **const names, > + int maxnames); Some indentation churn between this and later patches in the series, oh well. Not the end of the world. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list