On Fri, Apr 19, 2013 at 11:46:18AM +0200, Michal Privoznik wrote:
> On 18.04.2013 18:08, Christophe Fergeau wrote:
> > They are useful to tell libvirt-designer about which drivers
> > are install/will be installed in the OS associated with the domain.
> > This in turns allows libvirt-designer code to use these devices
> > when it's making some guesses about what to enable/not enable
> > in the VM being created.
> > ---
> > libvirt-designer/libvirt-designer-domain.c | 79 ++++++++++++++++++++++++++++++
> > libvirt-designer/libvirt-designer-domain.h | 5 ++
> > libvirt-designer/libvirt-designer.sym | 3 ++
> > 3 files changed, 87 insertions(+)
>
> > diff --git a/libvirt-designer/libvirt-designer.sym b/libvirt-designer/libvirt-designer.sym
> > index 7a24f2c..1dab447 100644
> > --- a/libvirt-designer/libvirt-designer.sym
> > +++ b/libvirt-designer/libvirt-designer.sym
> > @@ -10,6 +10,9 @@ LIBVIRT_DESIGNER_0.0.1 {
> > gvir_designer_domain_get_platform;
> > gvir_designer_domain_get_capabilities;
> >
> > + gvir_designer_domain_add_driver;
> > + gvir_designer_domain_remove_all_drivers;
> > +
> > gvir_designer_domain_add_cdrom_file;
> > gvir_designer_domain_add_cdrom_device;
> > gvir_designer_domain_add_disk_file;
> >
>
>
> I just realized, shouldn't these new symbols go to into new section
> LIBVIRT_DESIGNER_0.0.2?
IIRC, we explicitly broke ABI, so we should be incrementing the
soname and moving all symbols to a new version block
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list