On 04/17/2013 10:38 PM, Laine Stump wrote: > It occurred to me that we should only allow model='pci-root|pci-bridge' > if type='pci', and when I went back to look at the rng directly (instead > of just the diff), I noticed that there is already a separate set of > attributes/values allowable for type='virtio-serial'. So, especially > because there is already a precedent, I think there should be a separate > <group> for type='pci', just as there is for type='virtio-serial', and > it should allow model='pci-root|pci-bridge'. Of course this means that > the other attribute list will have to be moved inside the existing > <group> (and ideally, that group should be split into a separate group > for each type) > > I just made a patch that cleans up the controller rng as described above: > > http://www.redhat.com/archives/libvir-list/2013-April/msg01320.html > > Once it has been applied, you can just make the following change to > domaincommon.rng instead of what you did above: Yes, this is much nicer, as it means RNG won't validate a model for the wrong controller. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list