Re: [PATCH] Partially revert "cleanup: Don't include libvirt/libvirt.h"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/04/13 23:23, Eric Blake wrote:
This reverts the changes to remote_protocol.x made in commit
2d25fd4f410f65b40ef1c3d65124775a944f4025.  It turns out that
if 'dwarves' is installed, 'make check' fails if any *_LAST
enum values are visible from within the .o file compiled from
a .x file; including <libvirt/libvirt.h> prior to "internal.h"
is the documented way to avoid exposing *_LAST enum elements.
---

I pushed the fix before seeing this, though I like your
commit log more.

Osier

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]