The public headers libvirt/libvirt.h, libvirt/virterror.h, libvirt/libvirt-qemu.h, and libvirt/libvirt-lxc.h shouldn't be included in internal source directly. Osier Yang (10): cleanup: Remove the duplicate header cleanup: Only include testutils.h once cleanup: Don't include libvirt/libvirt.h cleanup: Don't include libvirt/virterror.h syntax-check: Don't include duplicate header syntax-check: Don't include "libvirt.h" and "virterror.h" in "" form syntax-check: Include libvirt.h and virterror.h in <> form only in external tools syntax-check: Don't include libvirt-{qemu,lxc}.h internally syntax-check: Include libvirt-{qemu,lxc}.h in <> form only in external tools docs: Update hacking cfg.mk | 106 ++++++++++++++++++++++++++++++++++++++ daemon/libvirtd.c | 1 - daemon/remote.c | 2 - docs/hacking.html.in | 8 +-- include/libvirt/libvirt-lxc.h | 2 +- include/libvirt/libvirt-qemu.h | 2 +- python/libvirt-lxc-override.c | 4 +- python/libvirt-override.c | 4 +- python/libvirt-qemu-override.c | 4 +- python/typewrappers.h | 4 +- src/conf/node_device_conf.c | 1 - src/libvirt-qemu.c | 1 - src/network/bridge_driver.c | 1 - src/nodeinfo.h | 1 - src/openvz/openvz_conf.c | 1 - src/openvz/openvz_driver.c | 1 - src/parallels/parallels_driver.c | 1 - src/phyp/phyp_driver.c | 2 - src/qemu/qemu_capabilities.h | 1 - src/qemu/qemu_driver.c | 1 - src/remote/remote_driver.h | 2 - src/remote/remote_protocol.x | 1 - src/security/security_selinux.c | 1 - src/uml/uml_driver.c | 1 - src/util/virkeycode.h | 1 - src/util/virnetdevtap.c | 1 - src/xen/xen_hypervisor.c | 1 - tests/domainsnapshotxml2xmltest.c | 4 +- tests/esxutilstest.c | 4 +- tests/lxcxml2xmltest.c | 4 +- tests/openvzutilstest.c | 4 +- tests/qemuargv2xmltest.c | 4 +- tests/qemuhelptest.c | 4 +- tests/qemumonitortest.c | 4 +- tests/qemuxml2argvtest.c | 4 +- tests/qemuxml2xmltest.c | 4 +- tests/qemuxmlnstest.c | 4 +- tests/shunloadhelper.c | 2 - tests/shunloadtest.c | 4 +- tests/vmx2xmltest.c | 4 +- tests/xml2vmxtest.c | 4 +- tools/virsh.c | 4 +- 42 files changed, 148 insertions(+), 66 deletions(-) -- 1.8.1.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list