On 15/04/13 18:51, John Ferlan wrote:
On 04/15/2013 02:28 AM, Osier Yang wrote:
*** BLURB HERE ***
Osier Yang (6):
cleanup: Remove the duplicate header
cleanup: Only include testutils.h once
cleanup: Don't include libvirt/libvirt.h
cleanup: Don't include libvirt/virterror.h
syntax-check: Don't include duplicate header
syntax-check: Don't include libvirt.h and virterror.h
cfg.mk | 34 ++++++++++++++++++++++++++++++++++
daemon/libvirtd.c | 1 -
src/conf/node_device_conf.c | 1 -
src/network/bridge_driver.c | 1 -
src/nodeinfo.h | 1 -
src/openvz/openvz_conf.c | 1 -
src/openvz/openvz_driver.c | 1 -
src/parallels/parallels_driver.c | 1 -
src/phyp/phyp_driver.c | 2 --
src/qemu/qemu_capabilities.h | 1 -
src/qemu/qemu_driver.c | 1 -
src/remote/remote_driver.h | 2 --
src/remote/remote_protocol.x | 1 -
src/security/security_selinux.c | 1 -
src/uml/uml_driver.c | 1 -
src/util/virkeycode.h | 1 -
src/util/virnetdevtap.c | 1 -
src/xen/xen_hypervisor.c | 1 -
tests/domainsnapshotxml2xmltest.c | 4 ++--
tests/esxutilstest.c | 4 ++--
tests/lxcxml2xmltest.c | 4 ++--
tests/openvzutilstest.c | 4 ++--
tests/qemuargv2xmltest.c | 4 ++--
tests/qemuhelptest.c | 4 ++--
tests/qemumonitortest.c | 4 ++--
tests/qemuxml2argvtest.c | 4 ++--
tests/qemuxml2xmltest.c | 4 ++--
tests/qemuxmlnstest.c | 4 ++--
tests/shunloadtest.c | 4 ++--
tests/vmx2xmltest.c | 4 ++--
tests/xml2vmxtest.c | 4 ++--
31 files changed, 60 insertions(+), 45 deletions(-)
Mechanically the series looks fine to me.
Although in 6/6 do the '@prohibit' and 'halt' lines need to have the
period escaped for libvirt.h and virterror.h? It seems the prohibit
entry might as I see another example "@prohibit='^# *include *<ctype\.h>'"
Yeah, it needs, I guess it works fine just because there is no
strings like (#include "libvirt/libvirt5h") in the source. Will change,
thanks.
Osier
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list