Re: [PATCH v4 11/11] Add test case for TPM passthrough

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/11/2013 11:43 AM, Daniel P. Berrange wrote:
On Fri, Apr 05, 2013 at 10:06:02AM -0400, Stefan Berger wrote:
Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Corey Bryant <coreyb@xxxxxxxxxxxxxxxxxx>
Tested-by: Corey Bryant <coreyb@xxxxxxxxxxxxxxxxxx>

---
  tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.args |    6 +++
  tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.xml  |   29 +++++++++++++++
  tests/qemuxml2argvtest.c                                 |    3 +
  tests/qemuxml2xmltest.c                                  |    2 +
  4 files changed, 40 insertions(+)
Since you implemented support for parsing -tpmdev args, you should
also add to tests/qemuargv2xmltest.c - the same data files can be
used for all 3 testcases.

Ok, so this creates quite some problems to have an XML generated that one doesn't have to edit afterwards, which I suppose is not expect. Should I just drop the parser code ?

  Stefan

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]