On 04/11/2013 08:35 AM, harryxiyou@xxxxxxxxx wrote: > From: Harry Wei <harryxiyou@xxxxxxxxx> > > virCommandNewArgList may return NULL so we need not > do following stuffs and just return '-1'. > > Signed-off-by: Harry Wei <harryxiyou@xxxxxxxxx> > CC: Osier Yang <jyang@xxxxxxxxxx> > CC: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/storage/storage_backend_sheepdog.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c > index 35a3a04..3452eaa 100644 > --- a/src/storage/storage_backend_sheepdog.c > +++ b/src/storage/storage_backend_sheepdog.c > @@ -120,6 +120,8 @@ virStorageBackendSheepdogRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED, > virCommandPtr cmd; > > cmd = virCommandNewArgList(COLLIE, "node", "info", "-r", NULL); > + if (cmd == NULL) > + return -1; NACK. virCommand is explicitly designed to allow NULL input on all intermediate commands, and finally report the error at virCommandRun() time, without burdening the caller with intermediate error checking. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list