On 10.04.2013 12:08, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > Instead of calling virCgroupForDomain every time we need > the virCgrouPtr instance, just do it once at Vm startup > and cache a reference to the object in virLXCDomainObjPrivatePtr > until shutdown of the VM. Removing the virCgroupPtr from > the LXC driver state also means we don't have stale mount > info, if someone mounts the cgroups filesystem after libvirtd > has been started > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > --- > src/lxc/lxc_cgroup.c | 17 ++- > src/lxc/lxc_cgroup.h | 2 + > src/lxc/lxc_conf.h | 2 +- > src/lxc/lxc_controller.c | 2 +- > src/lxc/lxc_domain.c | 2 + > src/lxc/lxc_domain.h | 3 + > src/lxc/lxc_driver.c | 354 +++++++++++++---------------------------------- > src/lxc/lxc_process.c | 39 +++--- > 8 files changed, 144 insertions(+), 277 deletions(-) ACK This is the last one I have reviewed today. I will resume tomorrow. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list