Re: [PATCH 06/18] Rename virCgroupMounted to virCgroupHasController & make it more robust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/04/2013 03:40 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> The virCgroupMounted method is badly named, since a controller can be
> mounted, but disabled in the current object. Rename the method to be
> virCgroupHasController. Also make it tolerant to a  NULL virCgroupPtr
> and out-of-range controller index, to avoid duplication of these
> checks in all callers
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/libvirt_private.syms |  2 +-
>  src/lxc/lxc_driver.c     | 12 +-----------
>  src/lxc/lxc_process.c    | 10 +++++-----
>  src/qemu/qemu_cgroup.c   | 14 +-------------
>  src/util/vircgroup.c     | 13 +++++++++----
>  src/util/vircgroup.h     |  2 +-
>  6 files changed, 18 insertions(+), 35 deletions(-)
> 

ACK

Jan

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]