Re: [PATCH] qemu: Remove maximum cpu limit when setting processor count using the API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/05/13 11:21, Daniel P. Berrange wrote:
On Fri, Apr 05, 2013 at 11:13:17AM +0200, Peter Krempa wrote:
On 04/05/13 10:37, Daniel P. Berrange wrote:
On Fri, Apr 05, 2013 at 12:11:31AM +0200, Peter Krempa wrote:
When setting processor count for a domain using the API libvirt enforced
a maximum processor count, while it isn't enforced when taking the XML path.

This patch removes the check to match the API.

Do you mean  s/API/XML/ here ?

Indeed.



I've fixed the commit message and ...


...


I don't see a way how we could reliably determine the maximum for a
guest before we start it and it doesn't make sense to start it to
find out. I think we should just remove the check and let qemu
handle the limit.

Ok, that makes sense now.


... pushed the patch now. If we decide that we still want to check the user supplied values we will need to do better than the code this patch removes.

Thanks.

Peter

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]